Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIU-396: Add additional port options to CLI for NodeManager. #277

Closed
wants to merge 1 commit into from

Conversation

myxie
Copy link
Collaborator

@myxie myxie commented Aug 12, 2024

  • Can now specify --rpc_port and --event_port.
  • Verified this works and two NodeManagers can be run using localhost.

- Can now specify --rpc_port and --event_port.
- Verified this works and two NodeManagers can be run using localhost.
@coveralls
Copy link

Coverage Status

coverage: 79.69% (-0.03%) from 79.722%
when pulling f9a013f on LIU-396
into 10110da on master.

@awicenec
Copy link
Contributor

I've merged this with the pyfunc_code branch and will then merge into master.

@awicenec awicenec closed this Aug 15, 2024
@myxie
Copy link
Collaborator Author

myxie commented Aug 15, 2024

@awicenec this wasn't complete, which is why it was in a draft state and the description was incomplete. I am still in the process of working on the unit-tests which are to be applied to this branch/set of changes.

I think in the future, there is value in keeping each individual branch's merge into main/master separate, as it means a revert of changes in the event there is a breaking change does not undo all branches. It also reduces the likelihood of merging incomplete work, as in this case.

@myxie
Copy link
Collaborator Author

myxie commented Aug 15, 2024

If you prefer the idea of merging multiple branches all at once into one branch and delivering that change, may I recommend the following?

If the current state of the branches are:

  • liu-XXX->master, PR 89
  • alt_featureX->master, PR 92
  • liu-XXY->master, PR 93

Create another branch off master with the intended version number, e.g. v.4.X.0, and then change the targets of each PR to that branch, merge each branch into that branch, and then merge the version branch into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants